see you tomorrow not sure of that

1024pix · Feb 5, 2025 · 7d45a16 · 7d45a16
1 parent 698c36c
commit 7d45a16
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 9 deletions.
diff --git a/api/src/quest/domain/models/Quest.js b/api/src/quest/domain/models/Quest.js
@@ -48,6 +48,8 @@ class Quest {
    * @param {Eligibility} eligibility
    */
   isEligible(eligibility) {
+    if (this.eligibilityRequirements.length === 0) return false;
+
     return this.eligibilityRequirements.every((eligibilityRequirement) =>
       this.#checkRequirement(eligibilityRequirement, eligibility),
     );

diff --git a/api/src/quest/domain/usecases/get-quest-results-for-campaign-participation.js b/api/src/quest/domain/usecases/get-quest-results-for-campaign-participation.js
@@ -3,6 +3,7 @@ import * as campaignParticipationRepository from '../../../prescription/campaign
 export const getQuestResultsForCampaignParticipation = async ({
   userId,
   campaignParticipationId,
+  dirtyImportcampaignParticipationRepository = campaignParticipationRepository,
   questRepository,
   eligibilityRepository,
   rewardRepository,
@@ -13,9 +14,10 @@ export const getQuestResultsForCampaignParticipation = async ({
     return [];
   }
 
-  const campaignParticipation = await campaignParticipationRepository.get(campaignParticipationId);
+  const campaignParticipation = await dirtyImportcampaignParticipationRepository.get(campaignParticipationId);
 
   const eligibilities = await eligibilityRepository.find({ userId });
+
   const eligibility = eligibilities.find(
     (eligibility) => eligibility.organizationLearner.id === campaignParticipation.organizationLearnerId,
   );

diff --git a/api/tests/quest/unit/domain/models/Quest_test.js b/api/tests/quest/unit/domain/models/Quest_test.js
@@ -7,6 +7,8 @@ import { expect } from '../../../../test-helper.js';
 
 describe('Quest | Unit | Domain | Models | Quest ', function () {
   describe('#isEligible', function () {
+    //TODO: add egde case quest without eligibilityRequirement to return false ?
+
     describe('when comparison is "all"', function () {
       describe('when data to test is a simple value', function () {
         let quest;

diff --git a/api/tests/quest/unit/domain/usecases/get-quest-results-for-campaign-participation_test.js b/api/tests/quest/unit/domain/usecases/get-quest-results-for-campaign-participation_test.js
@@ -4,7 +4,7 @@ import { getQuestResultsForCampaignParticipation } from '../../../../../src/ques
 import { expect, sinon } from '../../../../test-helper.js';
 
 describe('Quest | Unit | Domain | Usecases | getQuestResultsForCampaignParticipation', function () {
-  let campaignParticipationRepository;
+  let dirtyImportcampaignParticipationRepository;
 
   let questRepository, eligibilityRepository, rewardRepository, campaignParticipationId, userId;
 
@@ -13,7 +13,7 @@ describe('Quest | Unit | Domain | Usecases | getQuestResultsForCampaignParticipa
     campaignParticipationId = 2;
     questRepository = { findAll: sinon.stub() };
     eligibilityRepository = { find: sinon.stub() };
-    campaignParticipationRepository = { getCampaignByParticipationId: sinon.stub() };
+    dirtyImportcampaignParticipationRepository = { get: sinon.stub() };
     rewardRepository = { getByQuestAndUserId: sinon.stub() };
   });
 
@@ -47,8 +47,13 @@ describe('Quest | Unit | Domain | Usecases | getQuestResultsForCampaignParticipa
       }),
     ]);
 
+    dirtyImportcampaignParticipationRepository.get
+      .withArgs(campaignParticipationId)
+      .resolves({ organizationLearnerId: 10, targetProfileId: 50 });
+
     eligibilityRepository.find.withArgs({ userId }).resolves([
       new Eligibility({
+        organizationLearner: { id: 10 },
         campaignParticipations: [{ id: wrongCampaignParticipationId, targetProfileId: 40 }],
       }),
     ]);
@@ -59,7 +64,7 @@ describe('Quest | Unit | Domain | Usecases | getQuestResultsForCampaignParticipa
       userId,
       questRepository,
       eligibilityRepository,
-      campaignParticipationRepository,
+      dirtyImportcampaignParticipationRepository,
       rewardRepository,
     });
 
@@ -81,12 +86,13 @@ describe('Quest | Unit | Domain | Usecases | getQuestResultsForCampaignParticipa
         rewardId: 20,
       }),
     ]);
-    campaignParticipationRepository.getCampaignByParticipationId
-      .withArgs({ campaignParticipationId })
-      .resolves([{ targetProfileId: 40 }]);
+    dirtyImportcampaignParticipationRepository.get
+      .withArgs(campaignParticipationId)
+      .resolves({ organizationLearnerId: 10, targetProfileId: 40 });
 
     eligibilityRepository.find.withArgs({ userId }).resolves([
       new Eligibility({
+        organizationLearner: { id: 10 },
         campaignParticipations: [{ id: campaignParticipationId, targetProfileId: 40 }],
       }),
     ]);
@@ -97,7 +103,7 @@ describe('Quest | Unit | Domain | Usecases | getQuestResultsForCampaignParticipa
       userId,
       questRepository,
       eligibilityRepository,
-      campaignParticipationRepository,
+      dirtyImportcampaignParticipationRepository,
       rewardRepository,
     });
 

diff --git a/api/tests/quest/unit/infrastructure/repositories/eligibility-repository_test.js b/api/tests/quest/unit/infrastructure/repositories/eligibility-repository_test.js
@@ -35,7 +35,7 @@ describe('Quest | Unit | Infrastructure | repositories | eligibility', function
       // then
       expect(result[0]).to.be.an.instanceof(Eligibility);
       expect(result[0].organization).to.equal(organization);
-      expect(result[0].campaignParticipations.targetProfileIds[0]).to.equal(targetProfileId);
+      expect(result[0].campaignParticipations).to.deep.equal([{ targetProfileId }]);
       expect(result[0].organizationLearner.MEFCode).to.equal(mefCode);
     });
   });