tech(orga): getting ke directly, not snapshots, for campaignAssessmen…

…tParticipationResult
1024pix · Jan 31, 2025 · 007e707 · 007e707
1 parent 0cb19c2
commit 007e707
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/...pation/infrastructure/repositories/campaign-assessment-participation-result-repository.js b/...pation/infrastructure/repositories/campaign-assessment-participation-result-repository.js
@@ -49,8 +49,9 @@ async function _fetchCampaignAssessmentParticipationResultAttributesFromCampaign
 }
 
 async function _buildCampaignAssessmentParticipationResults(result, campaignLearningContent) {
-  const knowledgeElementsGroupedByUser = await knowledgeElementRepository.findSnapshotForUsers({
-    [result.userId]: result.sharedAt,
+  const knowledgeElementsGroupedByUser = await knowledgeElementRepository.findAssessedByUserIdAndLimitDateQuery({
+    userId: result.userId,
+    limitDate: result.sharedAt,
   });
   const knowledgeElements = Object.values(knowledgeElementsGroupedByUser).flat();
   const validatedTargetedKnowledgeElementsCountByCompetenceId =

diff --git a/api/src/shared/infrastructure/repositories/knowledge-element-repository.js b/api/src/shared/infrastructure/repositories/knowledge-element-repository.js
@@ -33,7 +33,7 @@ function _findByUserIdAndLimitDateQuery({ userId, limitDate, skillIds = [] }) {
   });
 }
 
-async function _findAssessedByUserIdAndLimitDateQuery({ userId, limitDate, skillIds }) {
+async function findAssessedByUserIdAndLimitDateQuery({ userId, limitDate, skillIds }) {
   const knowledgeElementRows = await _findByUserIdAndLimitDateQuery({ userId, limitDate, skillIds });
 
   const knowledgeElements = _.map(
@@ -51,7 +51,7 @@ async function findSnapshotForUsers(userIdsAndDates) {
     const userId = parseInt(userIdStr);
     let knowledgeElements = knowledgeElementsFromSnapshot;
     if (!knowledgeElements) {
-      knowledgeElements = await _findAssessedByUserIdAndLimitDateQuery({
+      knowledgeElements = await findAssessedByUserIdAndLimitDateQuery({
         userId,
         limitDate: userIdsAndDates[userId],
       });
@@ -64,7 +64,7 @@ async function findSnapshotForUsers(userIdsAndDates) {
 const findUniqByUserIds = function (userIds) {
   return Promise.all(
     userIds.map(async (userId) => {
-      const knowledgeElements = await _findAssessedByUserIdAndLimitDateQuery({
+      const knowledgeElements = await findAssessedByUserIdAndLimitDateQuery({
         userId,
       });
 
@@ -81,7 +81,7 @@ const batchSave = async function ({ knowledgeElements }) {
 };
 
 const findUniqByUserId = function ({ userId, limitDate, skillIds }) {
-  return _findAssessedByUserIdAndLimitDateQuery({ userId, limitDate, skillIds });
+  return findAssessedByUserIdAndLimitDateQuery({ userId, limitDate, skillIds });
 };
 
 const findUniqByUserIdAndAssessmentId = async function ({ userId, assessmentId }) {
@@ -96,7 +96,7 @@ const findUniqByUserIdAndAssessmentId = async function ({ userId, assessmentId }
 };
 
 const findUniqByUserIdAndCompetenceId = async function ({ userId, competenceId }) {
-  const knowledgeElements = await _findAssessedByUserIdAndLimitDateQuery({ userId });
+  const knowledgeElements = await findAssessedByUserIdAndLimitDateQuery({ userId });
   return knowledgeElements.filter((knowledgeElement) => knowledgeElement.competenceId === competenceId);
 };
 
@@ -131,6 +131,7 @@ const findInvalidatedAndDirectByUserId = async function (userId) {
 
 export {
   batchSave,
+  findAssessedByUserIdAndLimitDateQuery,
   findInvalidatedAndDirectByUserId,
   findSnapshotForUsers,
   findUniqByUserId,