Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Modification de l'apparence de PixFilterBanner (PIX-16053) #813

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

mcampourcy
Copy link
Contributor

@mcampourcy mcampourcy commented Jan 14, 2025

🎄 Problème

Le composant FilterBanner doit être mis à jour pour correspondre au design de Nebulix. Cette lise à jour a été découpée en plusieurs tickets.

🎁 Proposition

  • Modifier le niveau du bouton de suppression des filtres (primary to tertiary)
  • Déplacer le label “Filtrer par :" (avec ajout de l'icône à gauche) et appliquer le changement de tailles de texte
  • Enlever le background et les marges tournantes

🌟 Remarques

Avant
Capture d’écran 2025-01-14 à 16 18 53
Après
Capture d’écran 2025-01-14 à 16 18 15 (sans le fond bleu)

🎅 Pour tester

Vérifier que le composant correspond à la maquette

  • CI au vert

@mcampourcy mcampourcy added the 🚧 Development in progress Work In Progress label Jan 14, 2025
@mcampourcy mcampourcy self-assigned this Jan 14, 2025
@pix-bot-github
Copy link

Une fois l'application déployée, elle sera accessible à cette adresse https://ui-pr813.review.pix.fr
Les variables d'environnement seront accessibles sur scalingo https://dashboard.scalingo.com/apps/osc-fr1/pix-ui-review-pr813/environment

@mcampourcy mcampourcy force-pushed the pix-16053-change-pixFilter-appearance branch 5 times, most recently from 8e3df0e to 8531a68 Compare January 14, 2025 16:06
@mcampourcy mcampourcy changed the title [FEATURE] WIP - Change PixFilter appearance (PIX-16053- [FEATURE] Modification du l'apparence de PixFilterBanner (PIX-16053) Jan 14, 2025
@mcampourcy mcampourcy changed the title [FEATURE] Modification du l'apparence de PixFilterBanner (PIX-16053) [FEATURE] Modification de l'apparence de PixFilterBanner (PIX-16053) Jan 14, 2025
@mcampourcy mcampourcy force-pushed the pix-16053-change-pixFilter-appearance branch 4 times, most recently from 8c5d9e9 to be9e97c Compare January 14, 2025 16:26
Copy link
Member

@AndreiaPena AndreiaPena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌞

app/stories/pix-filter-banner.stories.js Show resolved Hide resolved
addon/components/pix-filter-banner.hbs Outdated Show resolved Hide resolved
@xav-car xav-car force-pushed the pix-16053-change-pixFilter-appearance branch from be9e97c to efba7dd Compare January 16, 2025 13:08
Copy link
Contributor

@xav-car xav-car left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

j'auto approve les corrections 😅

@pix-service-auto-merge pix-service-auto-merge merged commit dba7bad into dev Jan 17, 2025
7 of 8 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the pix-16053-change-pixFilter-appearance branch January 17, 2025 08:35
pix-service-auto-merge pushed a commit that referenced this pull request Jan 17, 2025
# [54.1.0](v54.0.1...v54.1.0) (2025-01-17)

### 🚀 Amélioration

- [#813](#813) Modification de l'apparence de PixFilterBanner (PIX-16053)
@pix-service-auto-merge
Copy link
Contributor

🎉 This PR is included in version 54.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants