[BREAKING] Utiliser les composants MS au lieu de FontAwesome (PIX-14433) #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois l'application déployée, elle sera accessible à cette adresse https://ui-pr731.review.pix.fr |
xav-car
force-pushed
the
pix-14433/use-pix-icon-on-components
branch
7 times, most recently
from
99bee06 to
a435431
Compare
xav-car
force-pushed
the
pix-14433/use-pix-icon-on-components
branch
15 times, most recently
from
b779db7 to
18cf99f
Compare
xav-car
added
the
⚠️ BREAKING CHANGES ⚠️
xav-car
force-pushed
the
pix-14433/use-pix-icon-on-components
branch
from
bea378c to
794b26b
Compare
QuentinChapelain-ui
approved these changes
Oct 11, 2024
pix-service-auto-merge
deleted the
pix-14433/use-pix-icon-on-components
branch
xav-car
changed the title
xav-car
pushed a commit
that referenced
this pull request
Oct 14, 2024
xav-car
pushed a commit
that referenced
this pull request
Oct 14, 2024
pix-service-auto-merge
pushed a commit
that referenced
this pull request
Oct 14, 2024
# [47.0.0](v46.15.2...v47.0.0) (2024-10-14) ### 💥 BREAKING CHANGE - [#731](#731) Utiliser les composants MS au lieu de FontAwesome (PIX-14433)
|
🎉 This PR is included in version 47.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
xav-car
removed
the
⚠️ BREAKING CHANGES ⚠️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💥 BREAKING_CHANGES
Changement des signatures pour les composants permettant l'usage d'icone custom
iconPrefix=>plainIconicon=>iconNamepour plus de cohérence entre les usages des composants.PixToggle => simplification de l'usage seulement avec des yield
<:on> <:off>, utilisation d'unuseIconsparams lorsqu'on introduit des icons dans les yields.PixMessage => suppression du type
alertdeprecated depuis 3 ansPixCollapsible prend seulement
<:title>et non plus un@title🎄 Problème
Nous utilisons encore les icon FA alors que nous avons notre composant PixIcon
🎁 Proposition
Utiliser PixIcon partout où FaIcon est utilisé
🌟 Remarques
Correction des Composants CSS
🎅 Pour tester
Vérifier que les composants modifié ont les bon icônes