Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get various accumulated fixes back into main #12

Merged
merged 11 commits into from
Jan 19, 2024
Merged

Get various accumulated fixes back into main #12

merged 11 commits into from
Jan 19, 2024

Conversation

BGluth
Copy link
Contributor

@BGluth BGluth commented Jan 18, 2024

All of the fixes over the past month have been on assorted_fixes. Since we're looking at getting withdrawal support done, we probably start thinking about getting this merged in.

BGluth and others added 10 commits January 18, 2024 14:49
- Handles an edge case where the first two bits are `0`.
- Actual fix needs to be done `eth_trie_utils`.
- Contains important fixes.
- Removed a lot of `println!`'s used for debugging.
- Cleaned up a few warnings.
@BGluth BGluth requested a review from Nashtare January 18, 2024 21:56
Copy link
Contributor

@Nashtare Nashtare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@BGluth BGluth merged commit 3f659a5 into main Jan 19, 2024
@BGluth BGluth deleted the assorted_fixes branch January 19, 2024 00:00
@Nashtare
Copy link
Contributor

@BGluth Now that assorted-fixes is merged to main, should we bump the deps on zero-bin:main as well?

@BGluth
Copy link
Contributor Author

BGluth commented Jan 20, 2024

Yeah I'll open a PR for that pretty soon. 👍

@Nashtare
Copy link
Contributor

nit: it's already included in my PR for the VerifierState, so probably not needed 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants