-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: mdbook guide #726
base: next
Are you sure you want to change the base?
docs: mdbook guide #726
Conversation
Operator installation
chain MMR faq
6f0e345
to
e22ce86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see that, few changes in structure but overall LGTM.
8cf9bd0
to
c0ec5ee
Compare
I've updated the PR with some minor changes. As discussed offline I'll leave this targeting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned offline, I think we need a clearer picture of which docs we want where before we merge this.
.github/workflows/book.yml
Outdated
# Only run deployment on push to main/next branches, not on PRs | ||
if: github.event_name == 'push' || github.event_name == 'workflow_run' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means pushes to main
and next
will overwrite each other. Probably we would want this to only happen on next
so that they're always the latest dev docs.
This PR adds an
mdbook
doc guide for node operators and developers.I've been staring at this for a bit too long; I think I've developed blind spots. Happy with any feedback.
Note: this includes a
mermaid.js
diagram - I'm not sure its that nice, there are maybe better formats to choose instead.Closes #244