Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mdbook guide #726

Open
wants to merge 24 commits into
base: next
Choose a base branch
from
Open

docs: mdbook guide #726

wants to merge 24 commits into from

Conversation

Mirko-von-Leipzig
Copy link
Contributor

This PR adds an mdbook doc guide for node operators and developers.

I've been staring at this for a bit too long; I think I've developed blind spots. Happy with any feedback.

Note: this includes a mermaid.js diagram - I'm not sure its that nice, there are maybe better formats to choose instead.

Closes #244

Copy link
Contributor

@phklive phklive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see that, few changes in structure but overall LGTM.

@phklive phklive requested a review from bobbinth March 4, 2025 15:38
@Mirko-von-Leipzig
Copy link
Contributor Author

I've updated the PR with some minor changes.

As discussed offline I'll leave this targeting next and open a new PR for main for the current v0.7 docs.

Copy link
Contributor Author

@Mirko-von-Leipzig Mirko-von-Leipzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned offline, I think we need a clearer picture of which docs we want where before we merge this.

Comment on lines 55 to 56
# Only run deployment on push to main/next branches, not on PRs
if: github.event_name == 'push' || github.event_name == 'workflow_run'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means pushes to main and next will overwrite each other. Probably we would want this to only happen on next so that they're always the latest dev docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants