This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8f9a6ac
to
647bd04
Compare
a4e4e35
to
aa4dfb9
Compare
Nemanja0x
reviewed
May 27, 2023
Nemanja0x
reviewed
May 27, 2023
Nemanja0x
reviewed
May 27, 2023
Nemanja0x
reviewed
May 27, 2023
12b8f41
to
5491b22
Compare
79e7065
to
f9398e1
Compare
39293a0
to
b85bf23
Compare
b85bf23
to
89ba7f6
Compare
Nemanja0x
approved these changes
May 30, 2023
Stefan-Ethernal
approved these changes
May 30, 2023
vcastellm
reviewed
May 30, 2023
vcastellm
reviewed
May 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a small code example on how a handler should be used?
vcastellm
reviewed
May 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a small code example on how a handler should be used in the PR body?
Example is here #1567 |
goran-ethernal
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vcastellm
approved these changes
Jun 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Forking Manager PoC
Example:
Let's say we have three forks: A, B, and C, with starting blocks 0, 10, and 20, respectively. For each fork, we have a simple handler that returns a string. We can achieve this using the code example below
Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Testing
Manual tests
Please complete this section if you ran manual tests for this functionality, otherwise delete it
Documentation update
Please link the documentation update PR in this section if it's present, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it