WIP DAB interface improvement #97
Conversation
There was a problem hiding this comment.
Awesome job @christophercampbell ! The PR needs a bit of polishing, but this goes beyond the expectations for the task 🎉
|
As a general note, and for further work, definitely out of scope for this PR: maybe it's worth exploring the possibility of different sources failing partially: for instance have some batches on local, some others on trusted and some others on DA, in a way that we dont need to ask for batches that already fetched from other sources |
|
Yes! I started to build it that way (thus the |
| @@ -58,6 +58,40 @@ func (c *Client) BatchByNumber(ctx context.Context, number *big.Int) (*types.Bat | |||
| return result, nil | |||
| } | |||
There was a problem hiding this comment.
BatchByNumber could probably invoke BatchesByNumbers. WDYT?
This is a WIP draft PR for DAB interface improvement, described here.