Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created & Updated README.md and added simple progress messages #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

samrdev
Copy link

@samrdev samrdev commented Nov 19, 2017

Sorry, that is my first pull requesting after forking in Github and I'm still finding out how this works. Thank you for appreciating my work and time to create the README.md. I hope you will merge my little progress additions, too. Thanks!

@0xLeon
Copy link
Owner

0xLeon commented Nov 22, 2017

No Problem. You could have actually just reuse the existing Pull Request. When you push commit to the same branch you used as base for the Pull Request, the new commit will also be added to the Pull Requests. That's why you usually use a separate branch for each feature you want to send a pull request for.

If poissible, plase separate these two features in this pull request and use one for each feature (Readme / Progress). That simplifies tracking some missing points for each feature separatly. I'll add some hints to the commits themselves in a few minuts, because there are some minor stylegoid related issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants