Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: directive editor background and Modal in dark mode #267

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

AnotiaWang
Copy link
Contributor

修复了前端深色模式下的两个问题:

  1. 有 3 处 Modal 的导入方式不对,导致在深色模式下 Modal 还是浅色
截屏2024-01-29 11 46 06
  1. 编辑站点的“指令”部分的注释背景没有适配深色模式
image

(顺便问一下,Modal 不加背景遮罩是有什么考虑吗?个人感觉层级有点不明显,并且其它一些地方的一些 Modal 又有遮罩

@0xJacky
Copy link
Owner

0xJacky commented Jan 29, 2024

感谢贡献,不加遮罩只是单纯觉得 antdv 的 mask 有点不太好看😂

@0xJacky 0xJacky merged commit 4c1112c into 0xJacky:dev Jan 29, 2024
10 checks passed
@AnotiaWang AnotiaWang deleted the fix/frontend-dark-mode branch January 29, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants