Non recursive eval_exp() to avoid stack overflow.
#252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvella
force-pushed
the
iteractive_eval_exp
branch
from
fcec08a to
1610838
Compare
eigmax
reviewed
May 3, 2024
| @@ -416,6 +416,43 @@ fn find_muladd(exp: &Expression) -> Expression { | |||
| exp.clone() | |||
| } | |||
|
|
|||
| /// Iteratively traverse a tree in postorder, so that the process stack doesn't overflow. | |||
There was a problem hiding this comment.
is there any sample code that will raise the stack overflow? hence we can add that as an unit test.
There was a problem hiding this comment.
I don't have any self contained code. This is the list of powdr tests that causes stack overflow, if executed in a rust thread with the default stack size (2MB):
- palindrome
- vm_to_block_unique_interface
- bit_access
- functional_instructions
But I am not sure why. I don't know what these tests have that makes the expressions so deep.
eigmax
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In powdr we have some tests that stack overflows inside
eval_exp(). This PR makeseval_exp()iterative, so it works on small stacks.