Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): Apply configuration sequentially #391

Merged
merged 3 commits into from
Jan 30, 2025
Merged

feat(client): Apply configuration sequentially #391

merged 3 commits into from
Jan 30, 2025

Conversation

0x676e67
Copy link
Owner

@0x676e67 0x676e67 commented Jan 30, 2025

This pull request focuses on refactoring the ClientBuilder and Config structures in the src/client/http.rs file to improve the handling of TLS configurations and headers. The most important changes include the introduction of a TlsConfig structure, removal of the HttpContext structure, and updates to various methods to reflect these changes.

Refactoring and improvements:

  • Replaced HttpContext with TlsConfig in Config struct and ClientBuilder methods. [1] [2] [3]
  • Added headers and headers_order fields to Config struct and updated related methods to use these fields. [1] [2] [3]
  • Updated ClientBuilder methods to use the new TlsConfig structure for TLS-related configurations. [1] [2] [3]
  • Simplified the impersonate method to update the Config struct directly with values from the HttpContextProvider.
  • Removed unnecessary imports and updated existing imports to reflect the refactoring changes. [1] [2]

@0x676e67 0x676e67 merged commit 775db82 into main Jan 30, 2025
4 checks passed
@0x676e67 0x676e67 deleted the feat branch January 30, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant