Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fmt imports #388

Merged
merged 1 commit into from
Jan 29, 2025
Merged

chore: fmt imports #388

merged 1 commit into from
Jan 29, 2025

Conversation

0x676e67
Copy link
Owner

@0x676e67 0x676e67 commented Jan 29, 2025

This pull request includes several changes to improve the consistency and functionality of the HTTP context configuration across different browser impersonations. The most significant changes involve refactoring function names and parameters to enhance clarity and maintainability.

Refactoring for improved clarity and consistency:

  • src/imp/chrome.rs, src/imp/firefox.rs, src/imp/okhttp.rs, src/imp/safari.rs: Renamed the function http_config to http_context and updated the function parameters to use ImpersonateOption instead of individual parameters for skip_http2 and skip_headers. [1] [2] [3] [4] [5]

  • src/imp/macros.rs: Updated the impersonate_match macro to use the new ImpersonateOption parameter instead of separate parameters for os, skip_http2, and skip_headers.

  • src/imp/mod.rs: Modified the HttpContextProvider implementation to use the new http_context function and updated the documentation to reflect the changes. [1] [2] [3]

Dependency and import adjustments:

  • src/client/http.rs: Reorganized and cleaned up the import statements to ensure all necessary dependencies are included and unused ones are removed.

@0x676e67 0x676e67 merged commit d73d1ac into main Jan 29, 2025
4 checks passed
@0x676e67 0x676e67 deleted the chore branch January 29, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant