Don't WaitForEvent when using IDebugControl::Execute
#221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debugging debugger / symbol related issues is easier when seeing the debugger output in the command line. For that users can turn on the following lines:
wtf/src/wtf/debugger.h
Line 261 in 1397403
Another facility that makes debugging easier is to be able to execute debugger commands like you are in WinDbg via
Execute. In the current implementation, after callingIDebugControl::ExecuteI wouldWaitForEventwhich seems to fail. This isn't a big deal but I've noticed that this has impact on, for example theIDebugSymbol3::GetOffsetByNamecall where it'll just return a catastrophic failure.The result is that, you are trying to figure out what's going wrong with your set-up, and maybe you do figure it out; but because
GetOffsetByNamefails because of the previousWaitForEvent(it seems) then you end up chasing an issue that doesn't exist which is frustrating.