Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#103] Feat: 업로드한 짤 페이지에서 짤 get api 구현 및 적용 #104

Merged
merged 5 commits into from
Mar 13, 2024
Merged

[#103] Feat: 업로드한 짤 페이지에서 짤 get api 구현 및 적용 #104

merged 5 commits into from
Mar 13, 2024

Conversation

Kim-Jaemin420
Copy link
Contributor

📝 작업 내용

좋아요 페이지와 전혀 다른게 없는 무한 스크롤을 사용한 get api 커스텀 훅입니다.
레이아웃도 모두 일치해서 따로 특이점은 없는 것 같습니다!

  • api 함수와 커스텀 훅 구현
  • 레이아웃 적용

close #103

@Kim-Jaemin420 Kim-Jaemin420 added the ✨ Feature 새로운 기능 추가 label Mar 5, 2024
@Kim-Jaemin420 Kim-Jaemin420 self-assigned this Mar 5, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zzalmyu-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 3:26am

choi-ik
choi-ik approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@choi-ik choi-ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋아요 한 짤 페이지랑 똑같군요!! LGTM!!!🚀🚀🚀🚀🚀🚀🚀🚀🚀 x 2조 2억 2천

yjc2021
yjc2021 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@yjc2021 yjc2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

HY219
HY219 reviewed Mar 6, 2024
View reviewed changes
Copy link
Contributor

@HY219 HY219 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

재민님 고생 많으셨습니다 👍

간단한 궁금증과 리뷰 달아봤습니다!

src/types/zzal.dto.ts Outdated Show resolved Hide resolved
hyeonjinan096
hyeonjinan096 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@hyeonjinan096 hyeonjinan096 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 LGTM 👍👍👍

@Kim-Jaemin420 Kim-Jaemin420 merged commit 7df8cd9 into main Mar 13, 2024
3 checks passed
@Kim-Jaemin420 Kim-Jaemin420 deleted the #103/feature/uploaded-zzals-get-api branch March 13, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HY219 HY219 HY219 left review comments

@hyeonjinan096 hyeonjinan096 hyeonjinan096 approved these changes

@choi-ik choi-ik choi-ik approved these changes

@yjc2021 yjc2021 yjc2021 approved these changes

Assignees

@Kim-Jaemin420 Kim-Jaemin420

Labels
✨ Feature 새로운 기능 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

업로드한 짤 페이지 get api 구현 및 적용
5 participants
@Kim-Jaemin420 @HY219 @yjc2021 @choi-ik @hyeonjinan096