Rain Overlay on Buildings that are indoors

[Sn1p3rr3c0n]

Reported by Kamikaze & smitty_the_smith on Steam Confirmed by me
Affects at least:

• Item Chute
• SAL's
  

in my initial tests i did not find additional ones

[rlking1985]

@Sn1p3rr3c0n

I'm new to rimworld and trying to get into it, apologies if I'm on the wrong track with these mods.

I'm not sure why this works but removing fillPercent from the following ThingDefs fixes the rain issue.

• Defs\ThingDefs_Buildings\Buildings_SAL_Like.xml > PRF_SAL_Base
• Defs\ThingDefs_Buildings\Buildings_Storage.xml > PRF_MassStorageBase

or,

changing the PRF_ItemSlide size to size(2,1), which isn't correct but stops the rain. Need to look more into how rimworld works to understand why that matters.

I know it's not the correct fix but might help someone get started on it.

Example

  <ThingDef Name="PRF_SAL_Base" ParentName="PRF_BuildingBase" Abstract="True">
    <defName>Building_NR_AutoMachineTool_Base</defName>
    <thingClass>ProjectRimFactory.AutoMachineTool.Building_AutoMachineTool</thingClass>
    <designatorDropdown>PRF_SALGroup</designatorDropdown>
    <altitudeLayer>Building</altitudeLayer>
    <uiIconScale>0.7</uiIconScale>
    <graphicData>
      <texPath>SAL3/SAL</texPath>
      <graphicClass>Graphic_Multi</graphicClass>
      <drawSize>(1,1)</drawSize>
      <shaderType>CutoutComplex</shaderType>    <!-- for mask to change color when stuffed -->
      <!-- <color>(133,97,67,256)</color> -->      <!--change color on maske manually -->
    </graphicData>
    <statBases>
      <MaxHitPoints>100</MaxHitPoints>
      <WorkToBuild>200</WorkToBuild>
      <Flammability>1.0</Flammability>
      <MarketValue>2780</MarketValue>
      <Mass>70</Mass>
    </statBases>
    <drawPlaceWorkersWhileSelected>true</drawPlaceWorkersWhileSelected>
    <!-- <fillPercent>1</fillPercent> --> <!-- Removing this line fixes the rain issue -->
    <comps>
    ...

[rlking1985]

@Sn1p3rr3c0n

Looks to be an issue for anything that has a size of (1,1) and fill percent 1. The Fermenting Tank also has the same issue. Suggest changing the fillpercent to 0.5 for any size (1,1) things.

[Sn1p3rr3c0n]

That would be one way, but the fill percentage also has an impact on the cover buildings provide.
.5 doses not seem right for those buildings.

Maybe the blockweather tag as proposed in: #778 would be better for those buildings.

Note: for the SAL I could maybe see a .8 or so, but but the fermenting tank should be 1.0 for sure

[rlking1985]

Good point, getting used to all the tags and considerations.

Agree with everything you said, fermenting tank make sense at 1.0 with block weather.

The mechanics/logic of having the SALs and possibly item chute at .8 mean that it provides some cover but not completely as they are smaller size than a fermenting tank etc?