Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crc32cHasher initial value should apply effect of refin #49

Open
lizhanhui opened this issue Nov 18, 2023 · 0 comments · May be fixed by #50
Open

Crc32cHasher initial value should apply effect of refin #49

lizhanhui opened this issue Nov 18, 2023 · 0 comments · May be fixed by #50

Comments

@lizhanhui
Copy link

Refer https://reveng.sourceforge.io/crc-catalogue/all.htm and https://github.com/mrhooray/crc-rs/blob/7e4b1b4879e3bb881f150b550f150df1ff199f04/src/crc32.rs#L60

The initial value should consider refin = true.
lizhanhui added a commit to lizhanhui/crc32c that referenced this issue Nov 18, 2023
@lizhanhui
fix zowens#49 consider effect refin with arbitary seed/initial value
f1ecd26 
Signed-off-by: lizhanhui <[email protected]>
@lizhanhui lizhanhui linked a pull request Nov 18, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consider effect of refin to arbitary seed/initial value lizhanhui/crc32c
1 participant
@lizhanhui