Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect from the group timetable that does not exist to the home screen instead of displaying HTTP 404 #60

Open
Igifigi opened this issue Sep 3, 2023 · 2 comments
Assignees

Comments

@Igifigi
Copy link
Contributor

Igifigi commented Sep 3, 2023

When you try to open group timetable that doesn't exist, you get HTTP 404. It'd more natural if you were redirected to the home page. Try this example: https://zorza.lo3.wroc.pl/timetable/groups/108,109,111,115,123,124/.

@DietPawel
Copy link
Contributor

I think it is more UX issue, and the solution could be improved to conform to RFC7231. Please see:

The 404 (Not Found) status code indicates that the origin server did
not find a current representation for the target resource or is not
willing to disclose that one exists.

When talking about redirects it is generally rule that:

The 307/301 status code indicates that the target resource resides under a different URI

Which is false if that groupset is just bad.

How about customizing 404 page with additional information? Probably a link to subset of requested groups that exist could be useful.

@Igifigi
Copy link
Contributor Author

Igifigi commented Sep 4, 2023

Mostly when you try to access group timetable with non-existing groups, you are opening some sort of url/bookmark to the last-year timetable. I thinks the most natural behavoir would be redirect to main page where you can open or customize your timetable.

@Igifigi Igifigi self-assigned this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants