Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For some Movies autofill does not work #47

Closed
CptPie opened this issue Jun 20, 2020 · 4 comments
Closed

For some Movies autofill does not work #47

CptPie opened this issue Jun 20, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@CptPie
Copy link
Collaborator

CptPie commented Jun 20, 2020

At the moment the current not working links are:
@CptPie CptPie added the bug Something isn't working label Jun 20, 2020
@CptPie
Copy link
Collaborator Author

CptPie commented Jun 20, 2020

The fix for this issue should be reviewed by both @zorchenhimer and myself

@CptPie
Copy link
Collaborator Author

CptPie commented Jun 20, 2020

In our current test db the issue is movie 23 which is the emoji only title which apparently gets checked as "".
This issue seems to be a issue of multiple things, on the one side the db check is broken for emojis, on the other side the autofill should be checked first (since the other inputs are ignored anyways).

@CptPie
Copy link
Collaborator Author

CptPie commented Jun 20, 2020

util.go:52 is the current culprit of this issue - The Cleaned name regex is omitting non ASCII characters -> Titles without any ascii characters get reduced to "" and the check fails for any autofill after that (should be fixed when the autofill box is checked first)
For further reference even japanese and emoji names are affected:
https://imgur.com/a/AAXXXRX

zorchenhimer added a commit that referenced this issue Jun 20, 2020
@zorchenhimer
Fix length checks for new movie title
4c4c824 
Remove the alphanumeric requirement for movie titles.  This originally
wouldn't allow all-Japanese titles to be added.  This relaxes the
duplicate check, but that needs some rethinking anyway.  See issue #47

Also added a zero length check to the movie title.
CptPie added a commit to CptPie/MoviePolls that referenced this issue Jun 20, 2020
@CptPie
Moved the autofillbox check before the other field checks
2d916b4 
This should fix one part of zorchenhimer#47, the movie title validation is still
todo.
@CptPie CptPie mentioned this issue Jun 20, 2020
Merged
CptPie added a commit to CptPie/MoviePolls that referenced this issue Jun 21, 2020
@CptPie
Merge branch 'hotfix-zorchenhimer#47' into restrictAPIResults-zorchen…
e974a83 
…himer#45
@CptPie
Copy link
Collaborator Author

CptPie commented Sep 4, 2020

Since i just checked the issues here is the current status of this issue:

@CptPie CptPie closed this as completed Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CptPie