Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morning session review #2

Open
orozCoding opened this issue Jan 4, 2022 · 1 comment
Open

Morning session review #2

orozCoding opened this issue Jan 4, 2022 · 1 comment

Comments

@orozCoding
Copy link

Congratulations for your code! ✌️ It is very short and clean ❤️

These are some little improvements you could add:

  • In the displayBooks function, you could skip the manual creation and manual appending of an additional
    if you add it to the li.innerHTML content, and if you append the remove button correctly.
  • The displayBooks() function's parameters can be minimized to one by simply passing the book object when it is called. And the properties can be found by object destructuring at the receiving end.
  • In the Readme file, the Authors could be displayed in their own section.

Keep it going! 👍

@zieeco
Copy link
Owner

zieeco commented Jan 4, 2022

Thanks and noted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants