Theme versioning (>v2.0.0)

[zetxek]

With the introduction of hugo modules, which are based on go modules, we are hitting a weird situation: the version 2.0.0 can't be found when trying to use it from a client.

The version is available both as a tag and as a release:

But it seems to lead to a version not found error...

When trying to use this as go.mod:

module github.com/zetxek/adrianmoreno.info
go 1.20
require github.com/zetxek/adritian-free-hugo-theme v2.0.0

This will raise a strange error:

go: errors parsing go.mod:
go.mod:5: require github.com/zetxek/adritian-free-hugo-theme: version "v2.0.0" invalid: should be v0 or v1, not v2
Error: failed to load modules: failed to download modules: failed to execute 'go [mod download -modcacherw]': failed to execute binary "go" with args [mod download -modcacherw]: go: errors parsing go.mod:
go.mod:5: require github.com/zetxek/adritian-free-hugo-theme: version "v2.0.0" invalid: should be v0 or v1, not v2
 *errors.errorString

Trying to use

module github.com/zetxek/adrianmoreno.info
go 1.20
require github.com/zetxek/adritian-free-hugo-theme/v2 v2.0.0

Will also result in another weird error:

➜  adrianmoreno.info git:(main) ✗ hugo mod get -u
go: github.com/zetxek/adritian-free-hugo-theme/[email protected]: go.mod has non-.../v2 module path "github.com/zetxek/adritian-free-hugo-theme" (and .../v2/go.mod does not exist) at revision v2.0.0
Error: failed to load modules: failed to download modules: failed to execute 'go [mod download -modcacherw]': failed to execute binary "go" with args [mod download -modcacherw]: go: github.com/zetxek/adritian-free-hugo-theme/[email protected]: go.mod has non-.../v2 module path "github.com/zetxek/adritian-free-hugo-theme" (and .../v2/go.mod does not exist) at revision v2.0.0

This seems to be caused by the strange versioning decisions made in go modules: https://go.dev/blog/v2-go-modules

Reading about the issue in hugo's forum (https://discourse.gohugo.io/t/update-module-to-v2/25843/2), the most pragmatic choice seems to be to stick to v1.x forever.

I don't want to version the code in folders or have to program for this specific weird behaviour. So adopting a v1.x.y schema seems to be the most effective, simple path.

[zetxek]

I have now made a change: removed the tags v2.x and replaced them by v1.5.x, including for the pre-releases.

Will test the behaviour now.

[zetxek]

It seems to work 🎉

With go.mod:

module github.com/zetxek/adrianmoreno.info

go 1.20

require github.com/zetxek/adritian-free-hugo-theme v1.5.0

The behaviour is as expected:

➜  adrianmoreno.info git:(main) ✗ hugo mod get -u
hugo: downloading modules …
hugo: collected modules in 2009 ms%

[zetxek]

See zetxek/adrianmoreno.info#272 for a "fix" for the versioning.
FYI @dcorto @mnordhaus, in case you have tried to upgrade to the module version - stick to v1.5.0, and do not try to get v2.x, and you should be alright :)

[zetxek]

I had already noticed something strange because go modules was referring to v1.4.28, that doesn't exist: https://github.com/zetxek/adritian-demo/pull/148/files

[mnordhaus]

Have you seen this? https://go.dev/blog/v2-go-modules So they basically say vN+1 changes should only happen when major breaking changes are introduced. It reads like an excuse but they say that would justify branches/direcrories … Seems odd to me.

…

On Sun, Jan 26, 2025 at 2:22 PM Adrián Moreno Peña ***@***.***> wrote: I had already noticed something strange because go modules was referring to v1.4.28, that doesn't exist: https://github.com/zetxek/adritian-demo/pull/148/files — Reply to this email directly, view it on GitHub <#171 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALQ3FBNBL2CB2N3TXZJAKL2MTOQVAVCNFSM6AAAAABV4NWKA6VHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTCOJVHAYTSNY> . You are receiving this because you were mentioned.Message ID: <zetxek/adritian-free-hugo-theme/repo-discussions/171/comments/11958197@ github.com>

[zetxek]

Yeah it sounds so far from the real world and so opinionated. I don't want to deal with sub folders and all that unnecessary complexity, so we'll stick with 1.x forever it seems 🤷‍♂️