Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide how to handle str vs bytes dtype input #21

Open
onishchenkod opened this issue Oct 4, 2024 · 0 comments
Open

Decide how to handle str vs bytes dtype input #21

onishchenkod opened this issue Oct 4, 2024 · 0 comments

Comments

@onishchenkod
Copy link
Contributor

So far default dtype to fir qnets on is string,
however bytestrings offer better memory efficiency that proved to be crucial in recent applications.

When qnet instance is fit on bytestrings, its outputs for qsampling etc. are in bytestrings as well, so this matters

I see two options:
1 - make qnets support both strings and bytestrings simultaneously.
2 - specify the accepted dtype at the creation of qnet instance and make it only accept the selected dtype input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant