Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML formatting in Zed is breaking Helm YAML parsing #9129

Closed
1 task done
Dmarcotrigiano opened this issue Mar 10, 2024 · 2 comments
Closed
1 task done

YAML formatting in Zed is breaking Helm YAML parsing #9129

Dmarcotrigiano opened this issue Mar 10, 2024 · 2 comments
Labels
bug [core label] language An umbrella label for all programming languages syntax behaviors yaml YAML data format support

Comments

@Dmarcotrigiano
Copy link

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

When saving my templated yaml file, zed formats the curly braces like shown below:

Screen Shot 2024-03-09 at 8 38 29 PM

The error in the terminal is resolved if I edit the file contents to remove the spaces in between curly braces, but when saving the file in Zed, the spaces are automatically added.

Screen Shot 2024-03-09 at 8 45 00 PM

After fixing the formatting on the braces, installing the helm chart works as expected.

Screen Shot 2024-03-09 at 8 46 10 PM

Create a helm template, and add a templated value such as

{{ .Values.name }}

Save the file and observe that it is changed to:

{ { .Values.name } }

Environment

Zed: v0.125.3 (Zed)
OS: macOS 12.7.3
Memory: 32 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

@Dmarcotrigiano Dmarcotrigiano added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Mar 10, 2024
@Moshyfawn
Copy link
Member

This is already being tracked in another issue. I'll close this one in favour of the other.

Duplicate of

@Moshyfawn Moshyfawn closed this as not planned Won't fix, can't repro, duplicate, stale Mar 10, 2024
@Moshyfawn Moshyfawn added yaml YAML data format support language An umbrella label for all programming languages syntax behaviors and removed triage Maintainer needs to classify the issue labels Mar 10, 2024
@JosephTLyons JosephTLyons removed the admin read Pending admin review label Mar 11, 2024
@RichardJECooke
Copy link

This fixed YAML problems in settings.json:

  "languages": {
    "YAML": {
      "format_on_save": "off"
    }
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] language An umbrella label for all programming languages syntax behaviors yaml YAML data format support
Projects
None yet
Development

No branches or pull requests

4 participants