Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: wrong activate command on fish #22708

Open
1 task done
dominik-muc opened this issue Jan 6, 2025 · 3 comments
Open
1 task done

python: wrong activate command on fish #22708

dominik-muc opened this issue Jan 6, 2025 · 3 comments
Labels
bug [core label] language An umbrella label for all programming languages syntax behaviors needs info / awaiting response Issue that needs more information from the user python Python programming language support terminal Feedback for terminal integration, shell commands, etc

Comments

@dominik-muc
Copy link

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

  1. Open a python project
  2. In your shell is automatically ran command source <project_path>/.venv/bin/activate
  3. This isn't working as intended. The proper command would be source <project_path>/.venv/bin/activate.fish

Zed Version and System Specs

Zed: v0.167.1 (Zed)
OS: Linux Wayland arch unknown
Memory: 15.5 GiB
Architecture: x86_64
GPU: AMD Radeon RX 6700 (RADV NAVI22) || radv || Mesa 24.3.2-arch1.1

If applicable, add screenshots or screencasts of the incorrect state / behavior

No response

If applicable, attach your Zed.log file to this issue.

Zed.log

@dominik-muc dominik-muc added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Jan 6, 2025
@osiewicz
Copy link
Contributor

osiewicz commented Jan 7, 2025

Do you have activate_script set to fish in your settings?
https://zed.dev/docs/configuring-zed#terminal-detect_venv

@JosephTLyons JosephTLyons added terminal Feedback for terminal integration, shell commands, etc python Python programming language support language An umbrella label for all programming languages syntax behaviors needs info / awaiting response Issue that needs more information from the user and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Jan 8, 2025
@dominik-muc
Copy link
Author

dominik-muc commented Jan 10, 2025

Adding this worked. Thank you very much and sorry for my overlook.

However wouldn't it be a nice addition for zed to read SHELL variable and set it automatically?

"activate_script": "auto"
And set it as default setting?

@choucavalier
Copy link

agreed! i think Zed should be smart about it and use the right activation script based on the auto-detected shell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] language An umbrella label for all programming languages syntax behaviors needs info / awaiting response Issue that needs more information from the user python Python programming language support terminal Feedback for terminal integration, shell commands, etc
Projects
None yet
Development

No branches or pull requests

4 participants