Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to toggle items on the Welcome page on Windows #22659

Closed
1 task done
0xtimsb opened this issue Jan 4, 2025 · 0 comments · Fixed by #22660
Closed
1 task done

Unable to toggle items on the Welcome page on Windows #22659

0xtimsb opened this issue Jan 4, 2025 · 0 comments · Fixed by #22660
Labels
admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue

Comments

@0xtimsb
Copy link
Contributor

0xtimsb commented Jan 4, 2025

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

There are two issues here:

  1. Currently, we don't watch the parent directory of a file if the file doesn't exist. As a result, on the first start of Zed, when settings.json hasn't been created yet (it gets created later, but the watcher doesn't detect it), the Welcome page fails to accept toggle clicks. Ironically, because the Welcome page is shown on the first launch, this issue likely affects all users.

  2. Symlinked files are currently not being watched on Windows, causing the UI to become unresponsive when settings.json is a symlink.

You can create a symlink on Windows using the Command Prompt.

For an absolute symlink:

mklink "C:\Users\tims\AppData\Roaming\Zed\settings.json" "C:\Users\tims\Desktop\settings.json"

or

For a relative symlink:

mklink "settings.json" "..\..\..\Desktop\settings.json"

Zed Version and System Specs

Zed: v0.169.0 (Zed Dev 8151dc7)
OS: Windows 10.0.26100
Memory: 31.7 GiB
Architecture: x86_64
GPU: Intel(R) UHD Graphics 770 || Intel Corporation || 101.6129

If applicable, add screenshots or screencasts of the incorrect state / behavior

first-start.mp4

If applicable, attach your Zed.log file to this issue.

Zed.log
@0xtimsb 0xtimsb added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Jan 4, 2025
@0xtimsb 0xtimsb mentioned this issue Jan 4, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 7, 2025
@0xtimsb
windows: Fix fs watch when file doesn't exist or is a symlink (#22660)
d3fc00d 
Closes #22659

More context can be found in attached issue.

This is specific to Windows:

1. Add parent directory watching for fs watch when the file doesn't
exist. For example, when Zed is first launched and `settings.json` isn't
there.
2. Add proper symlink handling for fs watch. For example, when
`settings.json` is a symlink.

This is exactly same as how we handle it on Linux.

Release Notes:

- Fixed an issue where items on the Welcome page could not be toggled on
Windows, either on first launch or when `settings.json` is a symlink.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

windows: Fix fs watch when file doesn't exist or is a symlink 0xtimsb/zed
1 participant
@0xtimsb