Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keybinding for inline assistant no longer works #22594

Open
1 task done
nated0g opened this issue Jan 2, 2025 · 18 comments
Open
1 task done

Keybinding for inline assistant no longer works #22594

nated0g opened this issue Jan 2, 2025 · 18 comments
Assignees
Labels
admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue

Comments

@nated0g
Copy link

nated0g commented Jan 2, 2025

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

I can no longer trigger the inline assistant with ctrl-enter. I can still trigger it with the icon:

image

, but the ctrl-enter hotkey no longer works. It doesn't work in either VISUAL or INSERT vim modes.

I'm not sure exactly when this started. I just noticed it today.

I have nothing in my ~/.config/zed/keymap.json, using all default keybindings.

My config, doesn't seem particularly relevant to the issue, but sharing anyway:

// Zed settings
//
// For information on how to configure Zed, see the Zed
// documentation: https://zed.dev/docs/configuring-zed
//
// To see all of Zed's default settings without changing your
// custom settings, run the `open default settings` command
// from the command palette or from `Zed` application menu.
{
  "assistant": {
    "default_model": {
      "provider": "copilot_chat",
      "model": "claude-3-5-sonnet"
    },
    "version": "2"
  },
  "vim_mode": true,
  "ui_font_size": 15,
  "project_panel": {
    "indent_size": 6,
    "auto_fold_dirs": false
  },
  "ui_font_family": "Zed Sans",
  "buffer_font_size": 14,
  "theme": {
    "mode": "system",
    "light": "One Light",
    "dark": "Catppuccin Frappé"
  },
  "buffer_font_family": "BerkeleyMono Nerd Font",
  "unstable.ui_density": "compact",
  "tab_bar": {
    "show_nav_history_buttons": false
  },
  "languages": {
    "Rust": {
      "show_inline_completions": true,
      "formatter": {
        "external": {
          "command": "rustfmt",
          "arguments": ["+nightly"]
        }
      }
    },
    "JavaScript": {
      "formatter": {
        "external": {
          "command": "eslint",
          "arguments": ["--fix", "."]
        }
      },
      "prettier": {
        "allowed": false
      },
      "code_actions_on_format": {
        "source.fixAll.eslint": true
      }
    },
    "lsp": {
      "rust-analyzer": {
        "diagnostics": {
          "enable": false
        },
        "initialization_options": {
          "cargo": {}
        }
      }
    },
    "code_actions_on_format": {
      "source.removeUnusedImports": true
    }
  },
  "context_servers": {
    "postgres-context-server": {
      "settings": {
        "database_url": "postgres://postgres:<REDACTED>"
      }
    }
  }
}

Zed Version and System Specs

Zed: v0.167.1 (Zed)
OS: macOS 15.2.0
Memory: 36 GiB
Architecture: aarch64

If applicable, add screenshots or screencasts of the incorrect state / behavior

No response

If applicable, attach your Zed.log file to this issue.

No response

@nated0g nated0g added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Jan 2, 2025
@4nur4g
Copy link

4nur4g commented Jan 3, 2025

I'm facing the same issue. The Inline assistant shortcut no longer works.

@sharjeel
Copy link

sharjeel commented Jan 3, 2025

I'm having the same issue on MacOS. Nothing shows up in the ~/Library/Logs/Zed either.

@taras-mrtn
Copy link
Contributor

The same issue in Zed 0.167.1

@Mauragkas
Copy link

the same issue in Zed dev 0.168.0

@cole-miller cole-miller self-assigned this Jan 4, 2025
@cole-miller
Copy link
Contributor

cole-miller commented Jan 4, 2025

If you're encountering this issue, could you try manually doing assistant: inline assist from the command palette and report

  • whether the assistant triggers successfully or not
  • whether Ctrl + <enter symbol> (or <Command symbol> + <enter symbol>) shows up to the right of assistant: inline assist in the command palette search results before you run the action?

(And make sure you're signed in with an LLM provider configured.)

Note for triage: I haven't been able to reproduce this on Linux, using Zed v0.167.1 signed in with a non-staff account.

@cidv0
Copy link

cidv0 commented Jan 4, 2025

It seems the changes in PR #22126 (‘Use the same InlineAssist action between both assistant and assistant2’) might be related. The PR unified the InlineAssist action and modified the CommandPaletteFilter, which could potentially affect the visibility or functionality of assistant: inline assist. I’ve noticed that the assistant: inline assist command doesn’t even appear in the command palette, which suggests it might not be properly registered or exposed.

@Mauragkas
Copy link

Mauragkas commented Jan 4, 2025

If you're encountering this issue, could you try manually doing assistant: inline assist from the command palette and report

* whether the assistant triggers successfully or not

* whether `Ctrl + <enter symbol>` (or `<Command symbol> + <enter symbol>`) shows up to the right of `assistant: inline assist` in the command palette search results before you run the action?

(And make sure you're signed in with an LLM provider configured.)

Note for triage: I haven't been able to reproduce this on Linux, using Zed v0.167.1 signed in with a non-staff account.

tried using the command palette and...
Screenshot_2025-01-04_23-29-30
weird, it does not appear in there but I can still use the button as nated0g did above. I came across this recently (3-5 days ago). I was using the zed-git from AUR at first and noticed it there, then switched to the plain zed fixed it at first then i think I updated the system and here we are. now the only thing it does is creating a new line above the selected text

@dinkopehar
Copy link

Happens to me also, Fedora 41. When I updated few days ago to v0.167.1 on Flatpak, Inline assist doesn't work using shortcut Ctrl + Enter. I tried to remap to different shortcut, but it still doesn't work. However, using it in Editor and Terminal by clicking a button of Inline Assist works. Logs don't show anything

@joshgoebel
Copy link

joshgoebel commented Jan 6, 2025

Same issue, keybind does not work and it's not listed in the command palette - it's only accessible via the button at the top of the UI.

@cole-miller
Copy link
Contributor

For affected users: can you see other assistant: actions in the command palette? And does cmd-?/ctr-? work to toggle the assistant panel?

@cidv0
Copy link

cidv0 commented Jan 6, 2025

I went to look and "assistant: inline assist" is back and cmd+enter now works. I am still on version Zed 0.167.1 on MacOS. Any idea what happened?

Edit: I did have the other assistant commands in the palette before, only one missing was inline assist.

@cole-miller
Copy link
Contributor

Two more questions for those affected---are you running Zed offline, i.e. not signed in? And which language model is configured for the inline assistant?

@cidv0
Copy link

cidv0 commented Jan 6, 2025

It's appears the cmd+enter key bind only works while signed in. I am using gpt-4o.

@nated0g
Copy link
Author

nated0g commented Jan 6, 2025

Two more questions for those affected---are you running Zed offline, i.e. not signed in? And which language model is configured for the inline assistant?

Yes, I was not signed in. Tried signing in and now it works again. It worked before without being signed in though.

I switch between gpt-4o and Claude 3.5 Sonnet

@joshgoebel
Copy link

For affected users: can you see other assistant: actions in the command palette?

Yes.

are you running Zed offline, i.e. not signed in?

Yes. Logging in seems to resolve this.

And which language model is configured for the inline assistant?

sonnet via github

@cole-miller
Copy link
Contributor

Thanks everyone, we've merged #22715 to fix this and point releases for stable and preview should be available shortly.

@nated0g
Copy link
Author

nated0g commented Jan 7, 2025

Working for me now in 0.167.2 (while not signed in), thanks!

@cidv0
Copy link

cidv0 commented Jan 7, 2025

Working for me now in 0.167.2 (while not signed in), thanks!

Same here! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue
Projects
None yet
Development

No branches or pull requests

9 participants