malformed keymap.json should trigger error on startup

[dlants]

Check for existing issues

• Completed

Describe the bug / provide steps to reproduce it

I got stumped for a while since I had this in my keyboard binding keymap.json file:

  {
    "context": "Terminal",
    "bindings": {
      "ctrl-h": ["pane::ActivatePrevItem"],
    }
  }

This caused all bindings to stop working in the terminal. Instead the terminal receives the keys (as seen in the screenshot).

screenshot

Changing this to just the string (instead of wrapped in the array braces) fixes the issue. It was just really tough to track down, I really thought something was horribly wrong.

Environment

Zed: v0.160.7 (Zed)
OS: macOS 14.6.1
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log

[notpeter]

The bug I see here is that if you enter Zed with a busted keymap, it should pop an error message and log an error to the Zed.log -- Zed currently fails silently in this case.

---

More info:

When you save the broken JSON keymap you should see an error message like this:

If not, can you provide an example invalid JSON keymap.json which does not trigger this error?

If you are editing the keymap and save making it invalid, we should alert and retain your previous-good settings. But if you've reopened Zed and have malformed JSON in your keymap, Zed will not attempt to partially load the broken JSON. This is by-design.