Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm #186

Closed
1 task done
ndgoodman opened this issue Dec 20, 2023 · 12 comments
Closed
1 task done

Helm #186

ndgoodman opened this issue Dec 20, 2023 · 12 comments
Labels
language A request to add a language extension

Comments

@ndgoodman
Copy link

Check for existing issues

  • Completed

Language

Helm

Tree Sitter parser link

No response

Language server link

https://github.com/mrjosh/helm-ls

Misc notes

No response

@ndgoodman ndgoodman added the language A request to add a language extension label Dec 20, 2023
@JosephTLyons JosephTLyons added language A request to add a language extension and removed language A request to add a language extension labels Dec 20, 2023
@JosephTLyons JosephTLyons transferred this issue from zed-industries/community Jan 24, 2024
@cabrinha
Copy link
Contributor

cabrinha commented Feb 1, 2024

May also be worth mentioning, helm uses go-templating: https://github.com/ngalaiko/tree-sitter-go-template

@JosephTLyons JosephTLyons changed the title helm support Helm Feb 26, 2024
@JosephTLyons JosephTLyons transferred this issue from zed-industries/zed Feb 26, 2024
@erste
Copy link

erste commented Mar 26, 2024

I've tried to create syntax highlighting extension https://github.com/erste/zed-helm using this fork of go-template grammar https://github.com/qvalentin/tree-sitter-go-template

It works but not quite as it should:

  • The language of *.yaml files always switches to YAML and there is no way to override this behavior.
  • Commenting doesn't always work.

@cabrinha
Copy link
Contributor

cabrinha commented May 17, 2024

@erste getting closer here, but I too could use some help on it: #746

Is it possible to add a language server to Zed? https://github.com/mrjosh/helm-ls/tree/master

@vualett
Copy link

vualett commented Aug 2, 2024

When we can see this implemented on new version of Zed ?

@suzaku
Copy link

suzaku commented Aug 19, 2024

Without K8s and Helm support, I'll have to continue using VSCode.

@ayr-ton
Copy link

ayr-ton commented Aug 20, 2024

Can you make something similar to helix?
https://github.com/helix-editor/helix/blob/9e7c488ee33eaabab6ee7c3436f4c58b8c647b4f/languages.toml#L3562

Like, if there's a Chart.yaml call helm_ls language server to all the yaml files below the Chart.yaml file? There's a lot of good ideas on the way helix handle the language servers configuration.

@marclop
Copy link

marclop commented Oct 16, 2024

I'd love to see helm support for Zed.

@crabique
Copy link

crabique commented Oct 16, 2024

@marclop Helm extension was merged today: https://github.com/zed-industries/zed/blob/main/docs/src/languages/helm.md#setup

@marclop
Copy link

marclop commented Oct 17, 2024

@crabique Thanks! It works great so far.

@ayr-ton
Copy link

ayr-ton commented Oct 18, 2024

@crabique you made our day with these news 😄

@cabrinha
Copy link
Contributor

This issue can be closed as complete.

@JosephTLyons
Copy link
Collaborator

Looks like we have an extension now, so I'm closing this out!

SCR-20241110-bsjv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language A request to add a language extension
Projects
None yet
Development

No branches or pull requests

9 participants