deprecate password_prompt
kwarg to OP()
#119
Labels
deprecation
work to be done to deprecate & remove some part of the API
refactor
refactoring work that isn't an enhancement
We need to deprecate and plan to remove the
password_prompt
kwarg for theOP()
constructor.Originally the purpose of this kwarg was:
OP_SESSION_<token>
set from previously authenticating,op
command to prompt for authentication on the console, or just fail hard?Now that authentications paths have gotten more complex (bio/no bio, service accounts, etc), and we have the
existing_auth=
kwarg, allowing the caller to specify "use if available", "ignore", or "required", thepassword_prompt
preference doesn't make any sense.We should do the following:
_new_or_existing_signin()
and_do_normal_signin()
where it gets used to rely exclusively onexisting_auth
OP()
password_prompt
is passed in asTrue
, either adjustexisting_auth
or possibly raise an exception if the values conflictThe text was updated successfully, but these errors were encountered: