Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Migrated] Handling non-dict SNS messages #27

Closed
jneves opened this issue Feb 20, 2021 · 0 comments
Closed

[Migrated] Handling non-dict SNS messages #27

jneves opened this issue Feb 20, 2021 · 0 comments

Comments

@jneves
Copy link
Contributor

jneves commented Feb 20, 2021

Originally from: Miserlou/Zappa#2198 by piotrdrazikowski

Description

The main SNS message handler incorrectly assumes that every message that was parsed using json.loads() without throwing an exception is of dict type, and then uses dict methods like .get() on the parsed object which eventually leads to a crash. In our case this has prevented us from sending a list of dicts, but there's more examples. This PR fixes it by handling the AttributeError exception

GitHub Issues

Miserlou/Zappa#1466
Miserlou/Zappa#1864

@jneves jneves closed this as completed Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant