Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser window doesn't reflect changes from Redux Devtools Extension #273

Closed
johnhamm opened this issue Dec 23, 2016 · 10 comments
Closed

Browser window doesn't reflect changes from Redux Devtools Extension #273

johnhamm opened this issue Dec 23, 2016 · 10 comments

Comments

@johnhamm
Copy link

I'm using Redux Devtools Extension 2.11.1.1 and ngrx/store 2.2.1

If I click Skip on an action in Redux DevTools (e.g. USER_LOGOUT), the browser window will still show the user logged in unless I click on the browser window somewhere and then it will update. This makes it impossible to use the timeline replay feature as the browser window won't update unless I click somewhere in it.

@johnhamm
Copy link
Author

Some further troubleshooting:

In my app module, I was using:
StoreDevtoolsModule.instrumentOnlyWithExtension(),

to setup support for this (awesome btw) extension. When I switched to:
StoreDevtoolsModule.instrumentStore({ monitor: useLogMonitor() }),

it caused the browser window to refresh correctly now when changes are made to the addon.

@zalmoxisus
Copy link
Owner

@johnhamm it should be fixed in ngrx/store-devtools#37. Make sure to use ngrx/[email protected].

@johnhamm
Copy link
Author

@zalmoxisus I'm using @ngrx/store-devtools 3.2.2

I was able to get it working, though, just by including the custom log monitor but not showing it (i.e. still using your amazing addon)

@zalmoxisus
Copy link
Owner

@johnhamm I'm not using @ngrx/store, angular and rxjs. So it would be difficult to me to investigate the problem. I just tried example-app and it works as expected. I added a book to the collection, and skipping Add Book Success removes the book. Could you please try this example too and try to dig into ngrx/store-devtools to see what is happening in you case?

@johnhamm
Copy link
Author

@zalmoxisus I just tried the example-app and it works as expected. I'm not sure why my app requires a click in the browser window for timetravel to work.

@zalmoxisus
Copy link
Owner

@johnhamm, maybe it's about a specific middleware like in #270.

@pixelypants
Copy link

pixelypants commented Jan 11, 2017

@zalmoxisus,
I got my app working with your redux devtools (slider/timetravel) yesterday (Brisbane, Australia) in chrome and today it stopped working. I can get it working in Firefox pointing to the same localhost:4200 endpoint and then I realised that you updated the chrome extension 10 hours ago.

Is there a way to rollback the extension to test it works on the previous version?

I'm using @ngrx/[email protected]
https://github.com/pixelypants/trubet-app

@zalmoxisus
Copy link
Owner

zalmoxisus commented Jan 11, 2017

@pixelypants thanks for the report. I've just fixed the issue with @ngrx/store-devtools api in 2b249b3. Will publish a patch in few hours.

Regarding earlier versions, Chrome doesn't store them. There's an unofficial archive, but don't know whether you can trust it. Also you can download and build a release right from github releases. However, I hardly recommend to use the latest version, and if there are any problems there to report here.

@zalmoxisus
Copy link
Owner

Should be fixed in 2.12.2. Please update it from Chrome Store. Let me know if there are still any issues with that.

@pixelypants
Copy link

Bingo! working fine now.

Thanks for your work on this, it's a great tool you have given the community ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants