From c1bf1e6d4bb1a9337d86c794ba9433cb48faa4c1 Mon Sep 17 00:00:00 2001
From: Zakaria Fadli <zakaria.fadli@legrand.com>
Date: Sun, 10 Nov 2024 04:36:32 +0100
Subject: [PATCH] Use clang 17 everywhere

---
 .github/workflows/build.yml | 3 ++-
 CMakeLists.txt              | 4 ++--
 README.md                   | 2 +-
 first_setup.sh              | 2 +-
 4 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index f6c549d..9db5283 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -14,7 +14,7 @@ jobs:
       - uses: actions/checkout@v3
 
       - name: Install other
-        run: sudo ./first_setup.sh
+        run: ./first_setup.sh
 
   configure:
     runs-on: ubuntu-latest
@@ -46,6 +46,7 @@ jobs:
     needs: configure
     steps:
       - uses: actions/checkout@v3
+
       - name: clang-tidy
         run: make clang-tidy
       
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 7ef96a0..8b5a26a 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -131,7 +131,7 @@ file(GLOB_RECURSE
 ############################################################
 
 # Add clang-tidy to the project
-find_program(CLANG_TIDY_EXE NAMES "clang-tidy-20")
+find_program(CLANG_TIDY_EXE NAMES "clang-tidy-17")
 
 if(CLANG_TIDY_EXE)
     message(STATUS "clang-tidy found: ${CLANG_TIDY_EXE}")
@@ -164,7 +164,7 @@ endif()
 
 # Add clang-format to the project only if version >= 17
 # using --version
-find_program(CLANG_FORMAT "clang-format-20")
+find_program(CLANG_FORMAT "clang-format-17")
 
 if(CLANG_FORMAT)
   message(STATUS "clang-format found: ${CLANG_FORMAT}")
diff --git a/README.md b/README.md
index 8589cd9..efe430b 100644
--- a/README.md
+++ b/README.md
@@ -4,7 +4,7 @@
 
 #### Build system
 - CMake 3.19 or later (to be able to use CMakePresets)
-- C++ compiler with C++23 support (Recommended clang-17+, The CI uses clang-20)
+- C++ compiler with C++23 support (clang 17)
 - ninja-build
 
 #### Static analyzes
diff --git a/first_setup.sh b/first_setup.sh
index 12926d1..effc364 100755
--- a/first_setup.sh
+++ b/first_setup.sh
@@ -9,4 +9,4 @@ apt-get install -y $PACKAGES
 # Install LLVM
 wget https://apt.llvm.org/llvm.sh
 chmod +x llvm.sh
-yes | ./llvm.sh 17 all
+yes | sudo ./llvm.sh 17 all