Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to define a target folder where to put the subset fonts #5

Closed
nhoizey opened this issue Jun 3, 2021 · 7 comments
Closed

Comments

@nhoizey
Copy link

nhoizey commented Jun 3, 2021

I would like the subset fonts to be created in a target folder different from the source folder where the full TTF is.

I can move the files myself of course, but this would be a little more convenient.

Thanks!

@nhoizey
Copy link
Author

nhoizey commented Jun 3, 2021

I tried to look at the code but didn't see where I could add this. If you have any advice, I can try to built it and make a PR.

@kid4git
Copy link

kid4git commented Dec 3, 2021

There is an apparently undocumented --output parameter that does just what you want. It works with relative and absolute paths. I detected it in cmd.js.

@nhoizey
Copy link
Author

nhoizey commented Dec 6, 2021

@kid4git it works indeed, thanks! 👍

@zachleat should I make a PR to update documentation with this feature, or do you prefer to keep it undocumented for a reason we don't know (yet)?

@nhoizey
Copy link
Author

nhoizey commented Dec 6, 2021

I see there was a PR on the filamentgroup repo: filamentgroup#64

@zachleat
Copy link
Owner

If you port that PR over I will merge it!

@nhoizey
Copy link
Author

nhoizey commented Dec 13, 2021

@zachleat done: #9

@nhoizey
Copy link
Author

nhoizey commented May 30, 2023

PR #9 already merged

@nhoizey nhoizey closed this as completed May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants