Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set limits for tablet nodes leads to full cluster upgrade with downtime #452

Open
Arustinal opened this issue Mar 3, 2025 · 3 comments
Open

Comments

@Arustinal
Copy link

how to reproduce

  1. create cluster with default spec without requests for tablet nodes
  2. wait for setup
  3. set requests
  4. see the whole system goes down

Is it really required?

@l0kix2
Copy link
Collaborator

l0kix2 commented Mar 3, 2025

I will try to reproduce, according to my expectations tablet nodes spec change shouldn't end in other components update.
Are you sure core image or some master-related configuration wasn't changed?

@l0kix2
Copy link
Collaborator

l0kix2 commented Mar 3, 2025

Oh, I see, we are consider tablet nodes as a component that triggers full update indeed.
Will look if it is necessary.

@l0kix2
Copy link
Collaborator

l0kix2 commented Mar 3, 2025

I don't think the updating all the components because of tablet nodes is necessary at this point. I assume originally it was done to control downtime via isFullUpdate flag — so if you update stateful components like master, data nodes, tablet nodes — you need to set isFullUpdate=true.
If we change current behaviour, it may break some users flows.
We will try to offer more granular mechanism for updates of different components in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants