Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split utils::WakerList into WakerVec and WakerArray #76

Closed
yoshuawuyts opened this issue Nov 15, 2022 · 1 comment · Fixed by #81
Closed

Split utils::WakerList into WakerVec and WakerArray #76

yoshuawuyts opened this issue Nov 15, 2022 · 1 comment · Fixed by #81
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@yoshuawuyts
Copy link
Owner

This works towards #68, but we should have a const-variant of the existing WakerList. Probably one way to do it would be to separate it by name: e.g. WakerVec (dynamic size) vs WakerArray (static size). This would make PRs like #75 faster and not rely on allocations.

@yoshuawuyts yoshuawuyts added enhancement New feature or request good first issue Good for newcomers labels Nov 15, 2022
@yoshuawuyts
Copy link
Owner Author

This should be a fairly straighforward copying of files, renaming some types, and doing a switch from Vec to using const-generics. It doesn't require any async-specific knowledge, and should be fairly straighforward to do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant