Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/Better Session And Auth Gestion #53

Open
dzove855 opened this issue Jun 28, 2019 · 4 comments
Open

Improvement/Better Session And Auth Gestion #53

dzove855 opened this issue Jun 28, 2019 · 4 comments
Assignees

Comments

@dzove855
Copy link

Is your feature request related to a problem? Please describe.
As for the moment, the authenfication and session is only based on the BASHSESSID and the cookie is not protected. So it's easy to get an man in the middle.

Describe the solution you'd like
We should split the session cookie and authenfication cookie. Something like BASHSESSID and BASHATUHID, and we should add Samoe-strict on auth cookie.

@dzove855
Copy link
Author

Before starting to code, i would like discuss with you how to do it correctly.

A double check on Authcookie and Sessioncookie to be sure the user is connected. Even a third cookie like DeviceID would be good too.

@lvenier @WustmannMatthias @misterbh

@lvenier
Copy link

lvenier commented Jun 28, 2019

I am not sure I understand the current issue. can you describe a bit more pls ?

@misterbh
Copy link

Security and cookie is always tricky
HTTP State Management Mechanism
https://tools.ietf.org/html/rfc6265

Servers that require a higher level of security SHOULD use the Cookie and Set-Cookie headers only over a secure channel. When using cookies over a secure channel, servers SHOULD set the Secure attribute (see Section 4.1.2.5) for every cookie. If a server does not set the Secure attribute, the protection provided by the secure channel will be largely moot.

Finally we probably have to add additional security to the web server top be safe

@dzove855
Copy link
Author

@misterbh Yep, that's true. Everything cookie default set, will have a configuration to enable secure attritubte. Also the authenifcation will not only be anymore set by a single cooke (Easy MID).

For the moment i still don't know how to do it, but it will have a look at others application's how they do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants