Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: allow configuration in TOML file with new TOML-native tox config #198

Open
Secrus opened this issue Oct 27, 2024 · 3 comments

Comments

@Secrus
Copy link

Secrus commented Oct 27, 2024

In recent versions tox got support for native TOML configuration. It would be nice to be able to configure tox-gh-actions in TOML too.

@abelcheung
Copy link

The bizarre thing is, it already works! But there's some trick: the version: factor part must be specified as a multiline string:

[tool.tox.gh-actions]
python = """
	3.8: py38
	3.9: py39
	3.10: py310
	3.11: py311
	3.12: py312
	"""

It takes advantage of fact that tox-gh-actions internally parses this part using string processing. @ymyzk may decide to revamp the syntax for TOML support. Or maybe not.

@Secrus
Copy link
Author

Secrus commented Oct 30, 2024

Yeah, but that is basically the same as what tox had before, inline INI syntax. Native TOML support should be nicer I guess.

@abelcheung
Copy link

Native TOML support should be nicer I guess.

Wish it could be too, but apparently not now. In particular, tox TOML config doesn't support conditioanl factor currently, and there is no replacement except going back to ini. Perhaps this issue can go hand in hand with #178 .

Anyway, it's already a bless I don't need to throw away tox-gh-actions right now while migrating to TOML.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants