You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I expect to be able to write major.minor.patch versions like 3.10.8 in my tox.ini's [gh-actions] section. If I write 3.10.8, I expect that to match a runner version of 3.10.8 but not 3.10.9. If I write just 3.10, I expect that to match a runner version of 3.10.8 or 3.10.9. If multiple entries in my tox.ini config match the runner version, I guess I expect the lexicographically first one to be used.
Additional context
N/A
The text was updated successfully, but these errors were encountered:
The problem should be caused by the fact that tox-gh-actions doesn't expect major.minor.patch as a key of gh-actions.python at this point. Here's the relevant code:
I think it makes sense to add the patch version support to tox-gh-actions. If you're open to create a MR for this change, feel free to do so. I might not be able to find time to implement this improvement by myself right now.
Describe the bug
If you have a config like this...
...and your GitHub Actions configuration installs 3.10.8, this plugin will select the
py310
environment instead of thepy3108
environment.To Reproduce
GitHub Action snippet:
tox.ini snippet:
The PR where I noticed this, showing the full configurations: pytest-dev/pytest-asyncio#817
And the specific job where I noticed this: https://github.com/pytest-dev/pytest-asyncio/actions/runs/8732675787/job/23960070899?pr=817
Expected behavior
I expect to be able to write
major.minor.patch
versions like3.10.8
in my tox.ini's[gh-actions]
section. If I write3.10.8
, I expect that to match a runner version of 3.10.8 but not 3.10.9. If I write just3.10
, I expect that to match a runner version of 3.10.8 or 3.10.9. If multiple entries in my tox.ini config match the runner version, I guess I expect the lexicographically first one to be used.Additional context
N/A
The text was updated successfully, but these errors were encountered: