From d0da85166d7fd3d750c3ad70e7e74778516220c9 Mon Sep 17 00:00:00 2001 From: abhiram-shaji <122574760+abhiram-shaji@users.noreply.github.com> Date: Mon, 11 Mar 2024 22:48:52 -0700 Subject: [PATCH 1/5] Fix sound button duplication error on victory --- app.js | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/app.js b/app.js index affd031..49d56eb 100644 --- a/app.js +++ b/app.js @@ -233,6 +233,8 @@ const checkWinner = () => { const winner_statement = document.getElementById("winner"); const audio = document.querySelector("audio"); + + if (res == "O") { if (gameMode == 1) winner_statement.innerText = "Player Won"; // Single player mode else winner_statement.innerText = "Player 1 Won"; // 2 player mode @@ -282,12 +284,15 @@ const checkWinner = () => { document.getElementById("draw1").innerText = temp5; document.getElementById("draw2").innerText = temp6; - if (loss1 == 1 || loss2 == 1 || draw1 == 1 || draw2 == 1) { //when the game ends, I create and add a button in the 'div-end-of-game' div - var btn = document.createElement("button"); - btn.className = "btn-sound"; - btn.innerHTML = ""; - btn.onclick = muteAudio; - document.getElementsByClassName("div-end-of-game")[0].appendChild(btn); + if (loss1 == 1 || loss2 == 1 || draw1 == 1 || draw2 == 1) { + // To check if the btn already exist + if (document.getElementsByClassName("btn-sound").length === 0) { + var btn = document.createElement("button"); + btn.className = "btn-sound"; + btn.innerHTML = ""; + btn.onclick = muteAudio; + document.getElementsByClassName("div-end-of-game")[0].appendChild(btn); + } } }; From 1750cb7e0868fda36f38d1dc248e370f3798b3de Mon Sep 17 00:00:00 2001 From: abhiram-shaji <122574760+abhiram-shaji@users.noreply.github.com> Date: Mon, 11 Mar 2024 22:54:52 -0700 Subject: [PATCH 2/5] Populated contributors html file --- contributors.html | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/contributors.html b/contributors.html index 0e1c9cd..e4edda9 100644 --- a/contributors.html +++ b/contributors.html @@ -25,10 +25,10 @@
CTR NO | -CONTRIBUTOR NAME | -CONTRIBUTOR GITHUB ID | -No OF CONTRIBUTIONS | +#132 | +Abhiram Shaji | +@abhiram-shaji | +One |
---|