False positive in BED_BOGUS_EXCEPTION_DECLARATION with jcabi-aspects

[mkordas]

The following code:

public final class Test implements Socket {
    ...
    @Override
    @RetryOnFailure
    public void connect() throws IOException {
        this.socket.connect();
    }
    ...
}

Causes [INFO] >> M C BED: Non derivable methodconnect()declares throwing an exception that isn't thrown.
However, both interface and this.socket.connect() declare `throws IOException', so I consider this as false positive.

Root cause here is annotation from jcabi-aspects on a method that throws correct exception. In that case fb-contrib can't findout that the exception is thrown. AspectJ must be doing some bytecode magic that makes it hard to detect.

Proposed solution is in #706 (comment)

---

[krzyk]

@mkordas could you post complete reproducer?

[krzyk]

@mkordas ping

[mkordas]

@krzyk I'll try to work on isolated reproducer tomorrow

[mkordas]

@krzyk cannot find isolated reproducer, closing for now

[krzyk]

@mkordas I think I found when the problem exists. If we have any annotation from jcabi-aspects on a method that throws correct exception, fb-contrib can't findout that the exception is thrown.
AspectJ must be doing some bytecode magic that makes it hard to detect.
I'm wondering how to prevent it (and how to report bug to fb-contrib).
Maybe do another compilation with aspectj disabled.

[mkordas]

@krzyk right, I was trying to reproduce in isolation without these annotations and I couldn't, so now it makes sense. Should I reopen the issue? I think that we should find workaround ASAP or check should be disabled, as it will cause too much noise for some projects (e.g retryable methods usually throw exceptions...)

[krzyk]

@mkordas yes, let's reopen it, we need to find a way to workaround it somehow.
By tuning the jcabi-maven-plugin to store the original classes in some directory and run findbugs on them.
I was thinking that we should:

1. check that output directory has a directory named unwoven, if it does then run FindBugs on it, if it doesn't exist then run it on the output directory.
2. document that behavior and document how to configure a project that uses jcabi-maven-plugin to support that
3. create a invoker test that uses the 2

[mkordas]

@krzyk issue reopened, description updated

[krzyk]

@davvd valid bug

[krzyk]

@davvd this is urgent

[yegor256]

@krzyk +1

[krzyk]

@yegor256 it would be easier to fix it with jcabi/jcabi-maven-plugin#45

[davvd]

@davvd valid bug

@krzyk tagged this issue with "bug"

[krzyk]

@davvd this is urgent

[davvd]

@davvd this is urgent

@krzyk thanks, I added "urgent" label

[davvd]

@davvd this is urgent

@krzyk "urgent" label already here

[davvd]

@gumbelmj could you please pick this up? This article explains how we work. Any technical questions you may ask right here. The budget here is 30 mins, which is exactly how much time will be paid for, when the task is completed

[gumbelmj]

@davvd please assign to someone else.

[davvd]

@davvd please assign to someone else.

@gumbelmj -30 points to your rating :(

[krzyk]

@davvd this is urgent

[davvd]

@davvd this is urgent

@krzyk OK, I put "urgent" label here

[davvd]

@davvd this is urgent

@krzyk OK, I un-labeled it as "postponed" tags

[davvd]

@dskalenko please pick this up, and keep in mind these instructions. Any technical questions - ask right here

The budget here is 30 mins, which is exactly how much time will be paid for, when the task is completed

[dskalenko]

@krzyk or @mkordas

I have implemented test to be able to fix the problem, now I am stuck , because I can't find elegant solution how I can get unwovenClassesDir parameter from jcabi-maven-plugin, I found something like this http://stackoverflow.com/questions/125389/best-way-to-access-the-runtime-configuration-of-a-maven-plugin-from-a-custom-mojo/130872#130872
Could you please give me advice how I can do it easily?

[krzyk]

@dskalenko I think we would need to wait for jcabi/jcabi-maven-plugin#48 to be fixed other option is to temporary disable BED_BOGUS_EXCEPTION_DECLARATION check and create a puzzle to implement it after jcabi/jcabi-maven-plugin#48 is done. Other options I think are too costly.

[dskalenko]

@krzyk
here my PR #781, please read description of PR before doing code review and let me know if I am done correctly for the moment, thanks

[davvd]

@dskalenko check this "no obligations principle".. This task is on your name for at least 15 days. If you can't close it within the next 48 hours I will have to assign someone else to it. This article should help if you're stuck; -30 added to your rating, current score is: +0

[krzyk]

@dskalenko now you have to ask mkordas to close the issue (if it fixes his problrm)

[krzyk]

@dskalenko ping

[dskalenko]

@mkordas Could you please check this issue and close if all good

[davvd]

@mkordas once 706-72bdab5d/#787 puzzle is resolved (later, in another ticket), this ticket will be fully complete

[krzyk]

@davvd this is not urgent

[davvd]

@davvd this is not urgent

@krzyk right, I removed "urgent" tag

[davvd]

@dskalenko Thanks so much! Your account was topped up for 30 mins (transaction ID is 91616835, the task took 482 hours and 3 mins)

added +30 to your rating, now it is equal to +30