Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiles and args for k8s #45

Open
kobzonega opened this issue Nov 20, 2024 · 2 comments
Open

profiles and args for k8s #45

kobzonega opened this issue Nov 20, 2024 · 2 comments

Comments

@kobzonega
Copy link
Contributor

kobzonega commented Nov 20, 2024

  1. Args --kubeconfig, --k8s-namespace, --k8s-context (like in kubectl) as optional params
  2. Add support thus params inside profile
  3. Use default kubeconfig path ~/.kube/config if param is not defined
  4. Use current context and namespace from kubeconfig if params is not defined
@kobzonega kobzonega changed the title profiles and arg for k8s profiles and args for k8s Nov 20, 2024
@Jorres
Copy link
Contributor

Jorres commented Nov 20, 2024

The only non-implemented thing from this list is --k8s-context parameter, everything else is implemented just like in this issue

@kobzonega
Copy link
Contributor Author

The only non-implemented thing from this list is --k8s-context parameter, everything else is implemented just like in this issue

As I understand it, the --k8s-namespace argument is now required with --kubeconfig. Just looking into this code https://github.com/ydb-platform/ydbops/blob/master/pkg/options/targeting.go#L111-L113
I think it should be better to use context with namespace enabled on kubeconfig when it's not overrided by ydbops args

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants