Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: Add generic query service #337

Closed
Zork33 opened this issue Dec 19, 2023 · 1 comment
Closed

dev: Add generic query service #337

Zork33 opened this issue Dec 19, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Zork33
Copy link
Collaborator

Zork33 commented Dec 19, 2023

Add generic query service to YDB SDK

The service suppose to be added the same as table service that already exists in YDB SDK.

Legend:

    □ - need to be written and tested

    ± - in the code, but not tested yet

    🗸 - done and tested
  1. □ As a prototype, can be used Query service implemented in .Net SDK
    (https://github.com/ydb-platform/ydb-dotnet-sdk/blob/main/src/Ydb.Sdk/src/Services/Query/QueryClient.cs)

It looks like one query method is required, and the other two are "sugar". It's likely because in .Net SDK positional arguments are used.
In TypeScript it looks more convenient to use named arguments, so that transaction, initial filling of accumulator, reduce method and can be easily combined in one method.

  1. □ In https://github.com/ydb-platform/ydb-nodejs-sdk/blob/main/src/types.ts convert types to js native. Double-check that
    all available YDB types are supported

Depends from:

@Zork33 Zork33 added the enhancement New feature or request label Dec 19, 2023
@Zork33 Zork33 self-assigned this Dec 19, 2023
@Zork33 Zork33 changed the title dev: Add generic requests service dev: Add generic queryservice Dec 20, 2023
@Zork33 Zork33 changed the title dev: Add generic queryservice dev: Add generic query service Dec 20, 2023
@Zork33
Copy link
Collaborator Author

Zork33 commented Dec 27, 2023

A detailed implementation plan has been added to the issue description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant