Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude backup shards from limit #1831

Open
kunga opened this issue Jan 16, 2025 · 3 comments
Open

Exclude backup shards from limit #1831

kunga opened this issue Jan 16, 2025 · 3 comments
Labels
status/need info Further information is requested 🐞 type/bug Something isn't working

Comments

@kunga
Copy link
Member

kunga commented Jan 16, 2025

In Scheme Shard we check shard limit excluding backup shards:

https://github.com/ydb-platform/ydb/blob/98f1bfcb2b2302a3cfd4d315a63ef55babc136e2/ydb/core/tx/schemeshard/schemeshard_path.cpp#L754

So we should also exclude them in UI checks: https://jing.yandex-team.ru/files/kungasc/2025-01-16_13-37-41.png

Now the bug leads to false-positive EMERGENCY status

@kunga kunga added the 🐞 type/bug Something isn't working label Jan 16, 2025
@antonkovalenko
Copy link
Member

@vporyadke looks like this exclusion has do be done at hc api side?

@antonkovalenko antonkovalenko added the status/need info Further information is requested label Jan 20, 2025
@vporyadke
Copy link

@vporyadke looks like this exclusion has do be done at hc api side?

yes, HC is missing this check

@kunga
Copy link
Member Author

kunga commented Jan 20, 2025

Perhaps we need two numbers in UI (also show backup shards count), not just subtract them on the backend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/need info Further information is requested 🐞 type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants