Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider developing on gitlab.com or other GitLab host #46

Open
kostajh opened this issue Oct 4, 2023 · 5 comments
Open

Consider developing on gitlab.com or other GitLab host #46

kostajh opened this issue Oct 4, 2023 · 5 comments

Comments

@kostajh
Copy link
Contributor

kostajh commented Oct 4, 2023

Then one could use gerritlab to develop gerritlab.

@dancysoft
Copy link
Collaborator

Then one could use gerritlab to develop gerritlab.

I would like this too.

@yaoyuannnn
Copy link
Owner

yaoyuannnn commented Nov 19, 2023

I have imported the project to GitLab at here. The GitLab CI has also been enabled. I will let you guys take a look and if things look good, we plan to transition the development to GitLab and make this GitHub repo a mirror of the GitLab repo.

@kostajh @dancysoft @thcipriani

@kostajh
Copy link
Contributor Author

kostajh commented Nov 24, 2023

@yaoyuannnn LGTM, thanks!

@yaoyuannnn
Copy link
Owner

yaoyuannnn commented Nov 27, 2023

I just found out that the free GitLab host doesn't come with the approver rules and the approvals are optional. I don't think we would want to transition to GitLab development without this feature, and GitLab premium doesn't seem to an option either.

@clonejo
Copy link
Collaborator

clonejo commented Nov 27, 2023

Notably Gitlab community edition (the free self-hosted tier) also has this limitation. At my org we just do approvals on a trust basis (which gerritlab can't act upon).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants