Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Update deprecated pandas dtype and distutils #840

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

hainaweiben
Copy link
Collaborator

  • Replace find_executable with shutil.which to address deprecation.
  • Resolve FutureWarning by ensuring compatible dtype in Pandas operations.
  • Explicitly cast values to match column dtype where necessary.

What do these changes do?

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

- Replace `find_executable` with `shutil.which` to address deprecation.
- Resolve `FutureWarning` by ensuring compatible dtype in Pandas operations.
- Explicitly cast values to match column dtype where necessary.
@XprobeBot XprobeBot added the enhancement New feature or request label Jan 9, 2025
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.80%. Comparing base (55aafbb) to head (e310a1b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #840      +/-   ##
==========================================
- Coverage   81.85%   81.80%   -0.06%     
==========================================
  Files        1071     1071              
  Lines       80149    80149              
  Branches    12201    12201              
==========================================
- Hits        65605    65564      -41     
- Misses      12990    13031      +41     
  Partials     1554     1554              
Flag Coverage Δ
unittests 81.70% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luweizheng luweizheng changed the title ENH: Fix deprecation warnings related to dtype and function usage ENH: Update deprecated pandas dtype and distutils Jan 9, 2025
Copy link
Collaborator

@luweizheng luweizheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luweizheng luweizheng merged commit 081d5f9 into xorbitsai:main Jan 9, 2025
21 of 23 checks passed
@hainaweiben hainaweiben deleted the fix/deprecation branch January 9, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants