Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: upgrade CI tests to python>=3.10 #837

Merged
merged 14 commits into from
Dec 23, 2024
Merged

Conversation

luweizheng
Copy link
Collaborator

What do these changes do?

  • Upgrade Python version >= 3.10 in python.yaml CI tests
  • SciPy's sparse array .A is deprecated, use .toarray() instead
  • remove xorbits.numpy's fetch_corner_data when printing large arrays to keep compatible with NumPy 2.1+: when printing large NumPy arrays, only the corner data was printed, with the middle part replaced by an ellipsis (...). DO NOT need a dedicated fetch_corner_data method, that prints the corner data of the array, anymore.
  • Update xorbits.numpy's histogram to 2.1+

Related issue number

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the enhancement New feature or request label Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.85%. Comparing base (b48e2dc) to head (290d73e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
+ Coverage   78.47%   81.85%   +3.37%     
==========================================
  Files        1071     1071              
  Lines       80176    80149      -27     
  Branches    12209    12201       -8     
==========================================
+ Hits        62921    65606    +2685     
+ Misses      15543    12983    -2560     
+ Partials     1712     1560     -152     
Flag Coverage Δ
unittests 81.75% <ø> (+3.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luweizheng luweizheng requested a review from hucorz December 23, 2024 15:11
Copy link
Collaborator

@hucorz hucorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hucorz hucorz merged commit 2da307d into xorbitsai:main Dec 23, 2024
22 of 23 checks passed
@luweizheng luweizheng deleted the build/ci branch December 24, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants