Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: set column name when using xorbits.pandas.Index #836

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

luweizheng
Copy link
Collaborator

Without this PR, this example will raise an error:

import xorbits.pandas as xpd

data = {"a": [1, 2, 3], "b": [4, 5, 6]}
xdf = xpd.DataFrame(data)

xdf.columns = xpd.Index(["c1", "d1"])
print(xdf)

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the bug Something isn't working label Dec 17, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.73%. Comparing base (607c3b9) to head (3817bb0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #836      +/-   ##
==========================================
- Coverage   82.79%   78.73%   -4.06%     
==========================================
  Files        1071     1071              
  Lines       80176    80176              
  Branches    12209    12209              
==========================================
- Hits        66378    63128    -3250     
- Misses      12253    15322    +3069     
- Partials     1545     1726     +181     
Flag Coverage Δ
unittests 78.63% <ø> (-4.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@hucorz hucorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hucorz hucorz merged commit b48e2dc into xorbitsai:main Dec 18, 2024
37 of 40 checks passed
@luweizheng luweizheng deleted the bug/column_setitem branch December 18, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants