Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: distributed xgboost.init with rabit deprecated, move to collective #805

Merged
merged 4 commits into from
Sep 2, 2024

Conversation

hucorz
Copy link
Collaborator

@hucorz hucorz commented Aug 30, 2024

What do these changes do?

change xgboost's rabit to collective

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the enhancement New feature or request label Aug 30, 2024
@XprobeBot XprobeBot added this to the v0.7.4 milestone Aug 30, 2024
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.97%. Comparing base (aa7ff1e) to head (3d2868d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #805      +/-   ##
==========================================
+ Coverage   81.94%   82.97%   +1.02%     
==========================================
  Files        1070     1070              
  Lines       79997    80004       +7     
  Branches    16534    16537       +3     
==========================================
+ Hits        65556    66385     +829     
+ Misses      12909    12021     -888     
- Partials     1532     1598      +66     
Flag Coverage Δ
unittests 82.88% <ø> (+1.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luweizheng luweizheng changed the title ENH: udpate xgboost's rabit to collective ENH: distributed xgboost.init with rabit deprecated, move to collective Sep 2, 2024
Copy link
Collaborator

@luweizheng luweizheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luweizheng luweizheng merged commit 3eb3d37 into xorbitsai:main Sep 2, 2024
31 of 33 checks passed
@hucorz hucorz deleted the fix-rabit-error branch October 14, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants