-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Fix DataFrame._data deprecated warnings #793
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #793 +/- ##
==========================================
+ Coverage 80.70% 80.71% +0.01%
==========================================
Files 1070 1070
Lines 80019 80019
Branches 16525 16525
==========================================
+ Hits 64581 64591 +10
+ Misses 13877 13866 -11
- Partials 1561 1562 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pandas deprecates
DataFrame._data
and recommends not to use it anymore.Pandas now use
DataFrame._mgr
instead.Here is the pandas PR of this update: pandas-dev/pandas#33333