Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Fix DataFrame._data deprecated warnings #793

Merged
merged 11 commits into from
Aug 19, 2024

Conversation

luweizheng
Copy link
Collaborator

Pandas deprecates DataFrame._data and recommends not to use it anymore.
Pandas now use DataFrame._mgr instead.
Here is the pandas PR of this update: pandas-dev/pandas#33333

@XprobeBot XprobeBot added the enhancement New feature or request label Aug 9, 2024
@XprobeBot XprobeBot added this to the v0.7.3 milestone Aug 9, 2024
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.71%. Comparing base (c4e4931) to head (c404cdc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #793      +/-   ##
==========================================
+ Coverage   80.70%   80.71%   +0.01%     
==========================================
  Files        1070     1070              
  Lines       80019    80019              
  Branches    16525    16525              
==========================================
+ Hits        64581    64591      +10     
+ Misses      13877    13866      -11     
- Partials     1561     1562       +1     
Flag Coverage Δ
unittests 80.67% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit 2991976 into xorbitsai:main Aug 19, 2024
29 of 36 checks passed
@luweizheng luweizheng deleted the enh/_data_mgr branch August 21, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants