Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: add user guide on lightgbm #751

Closed
wants to merge 4 commits into from

Conversation

traderbxy
Copy link
Contributor

@traderbxy traderbxy commented Oct 20, 2023

What do these changes do?

add lightgbm.rst at doc/source/libraries/xorbits_train

Related issue number

#714

@XprobeBot XprobeBot added this to the v0.7.0 milestone Oct 20, 2023
@traderbxy traderbxy changed the title add add .rst Oct 20, 2023
@traderbxy traderbxy changed the title add .rst DOC: add user guide on lightgbm Oct 20, 2023
@XprobeBot XprobeBot added the documentation Improvements or additions to documentation label Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Merging #751 (b54069f) into main (f67ffd4) will decrease coverage by 11.03%.
The diff coverage is n/a.

❗ Current head b54069f differs from pull request most recent head 24993da. Consider uploading reports for the commit 24993da to get more accurate results

@@             Coverage Diff             @@
##             main     #751       +/-   ##
===========================================
- Coverage   93.58%   82.55%   -11.03%     
===========================================
  Files        1058     1058               
  Lines       79780    79780               
  Branches    16504    16504               
===========================================
- Hits        74659    65866     -8793     
- Misses       3446    11636     +8190     
- Partials     1675     2278      +603     
Flag Coverage Δ
unittests 82.43% <ø> (-11.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 169 files with indirect coverage changes

@@ -0,0 +1,103 @@
.. _10min_lightgbm:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this lightgbm_example.rst file is redundant. Just keep the lightgbm.rst under xorbits_train dir.
And update the index.rst in xorbits_train dir to link the lightgbm.rst.

@XprobeBot XprobeBot modified the milestones: v0.7.0, v0.7.1 Oct 23, 2023
@traderbxy traderbxy closed this Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants